Add Support For 3D Scatter Plots and Line Plots (Closes #1463) #1572
Conversation
1. Add support for 3DScatter and LinePlots. 2. Refactor PlotlyDescExtractor to incoroprate3D Subplots 3. Extract 3D plots data from backend_deepforge.py 4. Minor changes to ExectionIndexControl 5. Change plotly.min.js to new version (v1.52.3) 6. Other minor changes
|
Would you mind adding an example pipeline to |
brollb
left a comment
brollb
left a comment
There was a problem hiding this comment.
Nice work. A couple minor changes. There are a few parts where it might be a little more complicated and I suspect it could be simplified but it's not a huge deal.
I still need to test it out locally but as long as there are no surprises, we should be good to go after the two minor comments are addressed!
src/common/viz/FigureExtractor.js
Outdated
|
|
||
| desc = { | ||
| id: id, | ||
| execId: execId, |
There was a problem hiding this comment.
It might be nice to reduce the code duplication between 2D and 3D plots. The only gotcha is that 3D plots don't support images. Maybe they could be refactored to add a method for the shared abstract base class in the metamodel and both could call it...
|
It looks like the graph container is not filling the entire space... This may not be related to 3D support (and may be better to address in its own issue/PR) but worth mentioning: |
3DScatterandLinePlots.PlotlyDescExtractorto incoroprate3D Subplotsbackend_deepforge.pyExectionIndexControlplotly.min.jsto new version (v1.52.3)