-
Notifications
You must be signed in to change notification settings - Fork 349
[Feat] Terraform Quickstart Tutorials for MS Azure #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Terraform Quickstart Tutorials for MS Azure #552
Conversation
Signed-off-by: falconlee236 <falconlee236@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @falconlee236, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly expands the cloud deployment options for the vLLM production stack by adding full support for Microsoft Azure Kubernetes Service (AKS). It provides all necessary Terraform configurations and detailed documentation to enable users to deploy GPU-accelerated ML inference workloads on Azure, offering a robust alternative to existing GKE deployments without introducing breaking changes.
Highlights
- Azure AKS Integration: This pull request introduces comprehensive Terraform configurations to enable the deployment of a GPU-accelerated vLLM production stack on Microsoft Azure Kubernetes Service (AKS). It provides a complete infrastructure setup, offering users a multi-cloud choice alongside existing GKE support.
- GPU-Accelerated Infrastructure: The new configurations provision an AKS cluster with specialized GPU node pools (using NVIDIA T4 GPUs on
Standard_NC4as_T4_v3VMs) and integrate the NVIDIA GPU Operator for efficient GPU management and allocation for ML inference workloads. - Comprehensive Monitoring and Observability: A full Prometheus monitoring stack is deployed, including GPU metrics and a Prometheus Adapter for custom vLLM metrics, ensuring enhanced observability of the deployed ML workloads.
- Automated Deployment Workflow: A new Makefile is added to streamline the entire deployment process, allowing for automated creation and destruction of both the Azure infrastructure and the vLLM Helm charts with simple commands.
- Detailed User Documentation: An extensive
README.mdguide is included, providing step-by-step instructions for setting up, testing, and troubleshooting the vLLM production stack on Azure, covering prerequisites, component details, GPU selection, and cleanup procedures.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a Terraform-based deployment guide for vLLM on Azure Kubernetes Service (AKS). The review focuses on improving documentation accuracy and fixing minor issues in automation scripts and Terraform configurations to enhance clarity and user experience.
Signed-off-by: falconlee236 <falconlee236@gmail.com>
4473083 to
e695da8
Compare
Signed-off-by: falconlee236 <falconlee236@gmail.com>
Signed-off-by: falconlee236 <falconlee236@gmail.com>
Signed-off-by: falconlee236 <falconlee236@gmail.com>
kobe0938
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
|
hey @falconlee236 Thanks for your contribution! Can you merge the latest changes? |
|
Hi @YuhanLiu11 And Can I work the production stack infrastructure about aws eks?? I wanna know your thoughts |
Definitely! That's seems to be the one last piece for Terraform. Feel free to contribute. Thanks. |
|
Thx to @kobe0938 @YuhanLiu11 , |
* add aks terraform feature Signed-off-by: falconlee236 <falconlee236@gmail.com> * apply gemini code review Signed-off-by: falconlee236 <falconlee236@gmail.com> * apply gemini code review 2 Signed-off-by: falconlee236 <falconlee236@gmail.com> * add blank line Signed-off-by: falconlee236 <falconlee236@gmail.com> * add new line Signed-off-by: falconlee236 <falconlee236@gmail.com> --------- Signed-off-by: falconlee236 <falconlee236@gmail.com> Signed-off-by: senne.mennes@capgemini.com <senne.mennes@capgemini.com>
Summary
Adds Azure Kubernetes Service (AKS) deployment option alongside existing GKE support, giving users choice between cloud platforms for GPU-accelerated ML inference workloads.
What's New
Infrastructure
File Structure
Key Components
Benefits
Impact
Considerations for Reviewers
AKS, post commit spell checking fail because ofAKSkeyword.FIX #271
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.