refactor(javascript): convert JS regexp PLIST to JSON #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamVerschueren
approved these changes
Nov 16, 2023
Contributor
SamVerschueren
left a comment
SamVerschueren
left a comment
There was a problem hiding this comment.
Nice work @fvsch !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PRs #5 and #7 we only have one XML PLIST file left:
For the reasons discussed in #7 and for the sake of consistency, this PR converts
jsregexp.tmLanguage. I've used the macOS built-inplutilcommand:I also tried an online PLIST-to-JSON converter, which seemed to generate a very similar output, only with some different whitespace formatting and ordering of keys.