Fix legacy score base multiplier being calculated using modded difficulty values #36209
Conversation
|
!diffcalc |
| if (flashlight is not null) | ||
| flashlightRating = osuRatingCalculator.ComputeFlashlightRating(flashlight.DifficultyValue()); | ||
|
|
||
| double sliderNestedScorePerObject = LegacyScoreUtils.CalculateNestedScorePerObject(beatmap, totalHits); |
There was a problem hiding this comment.
Maybe put WorkingBeatmap.Beatmap into a variable and use it in all places where we expect an unmodified beatmap? Even if it doesn't affect anything, just for clarity.
There was a problem hiding this comment.
Nope, this would be technically incorrect. CalculateNestedScorePerObject has some logic mirrored from the legacy simulator for spinners, and that logic is intentionally using this beatmap, not the working beatmap. Cross ref here:
osu/osu.Game.Rulesets.Osu/Difficulty/OsuLegacyScoreSimulator.cs
Lines 70 to 71 in e0c4592
There was a problem hiding this comment.
Oh, nvm, I misinterpreted your comment (since it's highlighting sliderNestedScorePerObject)
2 participants
Fun correctness bug.
ScoreV1 multiplier uses the nomod peppy stars (i.e the beatmap's "base" HP, OD and CS) in all cases, which was generally the intention with this code but it passes the wrong beatmap resulting in it using modded values for this.
Cross referenced with stable and this now results in the expected multipliers.
Results in some very minor (<3pp from my testing) changes for HR and EZ scores with combo breaks.