ext/standard: make php_escape_shell_arg() function private #20740
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From a quick SourceGraph search nobody uses this API outside of the corresponding PHP function
TimWolla
reviewed
Jan 2, 2026
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
I never had a reason to spawn processes from within an extension, but this seems useful to have without going through the userland call? I don't see much benefit in making this private, this doesn't simplify maintenance and the function is reasonably named.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a quick SourceGraph search nobody uses this API outside the corresponding PHP function.