Generalize mesh tally plotting #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
requested changes
Feb 2, 2024
Collaborator
pshriwise
left a comment
pshriwise
left a comment
There was a problem hiding this comment.
This is so great. Net total lines removed and now it's mesh-type agnostic! 🎊 📈
One comment on accounting for mesh filter translations, but other than that I'd say this is ready to go.
Contributor
Author
|
@pshriwise Just added in the mesh filter translation. Here is an example of it in action: |
Contributor
Author
|
@pshriwise I just updated this branch to add a volume normalization checkbox. |
pshriwise
requested changes
Feb 13, 2024
Collaborator
pshriwise
left a comment
pshriwise
left a comment
There was a problem hiding this comment.
I hammered on this a bit today and it's working great! Really fast loading times 🏎️
Just one comment on tally unit labels when volume normalization is bein applied.
pshriwise
approved these changes
Feb 15, 2024
Collaborator
pshriwise
left a comment
pshriwise
left a comment
There was a problem hiding this comment.
Looks good to me @paulromano! Pretty sweet to have this capability 🤩
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the mesh tally plotting capability in the plotter only works with
RegularMeshtallies. This PR generalizes the mesh tally capability to work for any mesh type by leveraging the newget_plot_binsmethod introduced in openmc-dev/openmc#2854. Here's an example showing a spherical mesh tally plotted: