Skip to content

Conversation

@joshtrichards
Copy link
Member

  • Resolves: #

Summary

  • Fix/robustness: The progress reporting is now consistent: both advance/progress and finish messages use the same variable for total steps (there was a risk previously, albeit a small one, that the most recent would be reported as the total step denominator)
  • Fix/robustness: Each message construction trims and safely defaults the description or message field so that empty values are handled gracefully.
  • Readability: Each event type is now dispatched to a dedicated private handler method
  • Readability: Variable names adjusted to make the intent of the variables much clearer
  • Maintainability: More descriptive class-level and method comments help clarify intended use and logic.

Retains original behavior/business logic. Only potential user-facing output changes are the fix/robustness items noted above, which are only applicable in rare edge cases and are ultimately fixes for bugs.

TODO

  • ...

Checklist

…r event handling

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added bug feature: install and update ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Dec 29, 2025
@joshtrichards joshtrichards changed the title refactor(core): improve readability and robustiness of FeedBackHandler refactor(core): improve readability and robustness of FeedBackHandler Dec 29, 2025
Signed-off-by: Josh <josh.t.richards@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug feature: install and update ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants