refactor(twofactor_backupcodes): migrate to Typescript and Vue 3 #56067
+490
−486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
ChristophWurst,
miaulalala and
nickvergessen
as code owners
susnux
added
3. to review
susnux
requested review from
artonge,
leftybournes,
sorbaugh,
szaimen and
yemkareems
and removed request for
a team
31 tasks
skjnldsv
approved these changes
Oct 29, 2025
skjnldsv
reviewed
Oct 29, 2025
| "@nextcloud/password-confirmation": "^6.0.1", | ||
| "@nextcloud/paths": "^2.2.1", | ||
| "@nextcloud/vue": "^9.0.1", | ||
| "pinia": "^3.0.3", |
Member
There was a problem hiding this comment.
Whaaaaat, how is this an addition?
We use Pinia on files, the dep should already be here 🤔
Member
There was a problem hiding this comment.
AH yes, I forgot we moved the pkg into build
Contributor
Author
There was a problem hiding this comment.
its the first Vue 3 app that uses pinia :)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…pescript Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/twofactor-vue3
branch
from
9048741 to
9008175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
best to view commit by commit.
Checklist
3. to review, feature component)stable32)