[RFR] Remove ra-realtime #3908
Merged
[RFR] Remove ra-realtime #3908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2019
This was referenced Dec 1, 2019
7 tasks
|
hello, any chance to restore or re-implement this feature in the near future, if at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ra-realtime module is more a proof-of-concept. Trying to use it in 3.0 lead to a dead end. Is it broken? Is the documentation outdated?
As sagas aren't the preferred way to set up side effects, the implementation is also not adapted to the v3 architecture. The right way to do it is to use a global EventListener and to interact with it from the
dataProvider.The v3 release is too close to refactor ra-realtime, so we'd better remove it.