Skip to content

Conversation

@davidzhao
Copy link
Member

@davidzhao davidzhao commented Dec 19, 2025

since multiple responses could be returned, we should not raise an error on trailing empty responses

fixes #4307

since multiple responses could be returned, we should not raise an error
on trailing empty responses
@davidzhao davidzhao requested a review from a team December 19, 2025 07:00
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I'll fix ruff tmrw

@davidzhao davidzhao merged commit 068147d into main Dec 19, 2025
16 of 18 checks passed
@davidzhao davidzhao deleted the fix-gemini-content-generation branch December 19, 2025 07:36
wasaybaig201 pushed a commit to wasaybaig201/agents that referenced this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression]livekit-plugins-google LLM streaming fails on empty final chunks from Gemini API

3 participants