add comma at the end of input if none is provided #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@nicholsk18 Thanks! I can reproduce the issue with space-delimited email addresses in To/Cc/Bcc. I'll review the patch. In validation, we can probably check the length of the the recipients in each field. If our parsed value is empty we'd also know something went wrong. |
Contributor
Author
|
Backend would be great to add, but I think for UX it be nice to have something in front end as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less a quick fix, but no validation if staff types in two emails without a comma in any of the 3 fields shown here. You can hit send and it will never send to anyone as far as I am aware. To headers are missing and no error anywhere. This adds a comma on space key if it is needed.