Skip to content

Conversation

@CreativeLau
Copy link
Contributor

No description provided.

Copy link
Member

@HuguesDelorme HuguesDelorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the changes should just check if cmake generator is VisualStudio. If yes then straight add /MP to Mayo_CompileOptions cmake variable

@CreativeLau
Copy link
Contributor Author

Definitely, it should be modified as your recommendation. I have changed the pull request.

Copy link
Member

@HuguesDelorme HuguesDelorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of /MP should happen only when cmake generator is VisualStudio(ie cmake creates VisualStudio projects)
Otherwise this option will break build of other make systems(eg ninja, nmake, ...)

@CreativeLau
Copy link
Contributor Author

Yes, the /MP will be appended only if the compiler is MSVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants