Skip to content

Conversation

@mozzius
Copy link
Contributor

@mozzius mozzius commented Dec 26, 2025

Summary:

Fixes #54983

#54983 has more details, but in short, this code here:

currentIdleCallbackRunnable?.cancel()
currentIdleCallbackRunnable = IdleCallbackRunnable(frameTimeNanos)
reactApplicationContext.runOnJSQueueThread(currentIdleCallbackRunnable)

If currentIdleCallbackRunnable change between line 2 and line 3 (which is known to happen), the wrong runnable would be sent to be run. The fix is to simply capture it in a local variable before passing it to be run

currentIdleCallbackRunnable?.cancel()
val idleCallbackRunnable = IdleCallbackRunnable(frameTimeNanos)
currentIdleCallbackRunnable = idleCallbackRunnable
reactApplicationContext.runOnJSQueueThread(idleCallbackRunnable)

Changelog:

[ANDROID] [FIXED] - Capture idle callback before running it

Test Plan:

Unfortunately this is a pretty speculative change. That said, since the change is so simple, the worst thing that can happen is nothing. I have also run it in production here with no known issues
bluesky-social/social-app#9436

@meta-cla
Copy link

meta-cla bot commented Dec 26, 2025

Hi @mozzius!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Dec 26, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 26, 2025
@meta-cla
Copy link

meta-cla bot commented Dec 26, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 26, 2025
@meta-codesync
Copy link

meta-codesync bot commented Jan 5, 2026

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this in D90120471.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync bot closed this in 90e48d6 Jan 5, 2026
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 5, 2026
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mozzius in 90e48d6

When will my fix make it into a release? | How to file a pick request?

@meta-codesync
Copy link

meta-codesync bot commented Jan 5, 2026

@lunaleaps merged this pull request in 90e48d6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

4 participants