network: add --mac-address support to docker network connect
#6728
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--mac-addresssupport todocker network connectCloses #51796
This change adds support for specifying a MAC address when connecting an existing container to a network using
docker network connect, bringing feature parity withdocker run --network.The flag follows the same behavior as existing network-related options such as
--ipand--ip6. The MAC address is parsed and validated client-side, then forwarded to the daemon viaEndpointSettings.MacAddress.This is particularly useful for macvlan networks, where explicit MAC address assignment is a common requirement.
Note: This change requires a companion update in
moby/mobyfor the daemon to actually apply the MAC address during network connection.What I did
--mac-addressflag todocker network connectEndpointSettings.MacAddressto the daemonHow I did it
net.ParseMACnetwork.HardwareAddrbefore sending it to the APIHow to verify it