Add support for interactive compute. Closes #1691 #1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There are still some remaining items:
|
3 tasks
brollb
commented
May 14, 2020
| } | ||
|
|
||
| // Some functions for event support | ||
| on (ev, cb) { |
Contributor
Author
There was a problem hiding this comment.
This class should just inherit from EventEmitter
brollb
commented
May 14, 2020
| emit (ev) { | ||
| const args = Array.prototype.slice.call(arguments, 1); | ||
| const handlers = this._events[ev] || []; | ||
| return Promise.all(handlers.map(fn => fn.apply(this, args))); |
Contributor
Author
There was a problem hiding this comment.
The emit method in EventEmitter should return a promise, too.
Contributor
Author
|
Server URL detection will become a non-issue after webgme/webgme-engine#212 is addressed as it will be able to reuse the existing ws connection. |
Contributor
Author
|
This is now only waiting on the new websocket API to be exposed by webgme-engine and then will need to be updated to use it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for interactive compute. That is, it enables visualizers to create an interactive session using a compute adapter and to use the compute for various calculations, etc.