feat(geeksforgeeks): init #2028
Conversation
uncenter
left a comment
uncenter
left a comment
There was a problem hiding this comment.
Note: I was unable to run
deno task generatelocally to create the README and other assets. Please run the generation script or let the CI handle it.
As the error message says, that script is not intended to be used locally. Those assets are generated once this pull request is merged to main. Please read our https://userstyles.catppuccin.com/contributing/ to understand our protocols. Note that https://userstyles.catppuccin.com/contributing/creating-userstyles/ does not mention generating assets with our CI only scripts.
uncenter
added
0.kind: init
|
Ran the linter, you can see what changes you need to make under the Files changed tab |
uncenter
left a comment
uncenter
left a comment
There was a problem hiding this comment.
The page looks pretty unthemed? Is this ready for review?
|
|
||
| input:focus { | ||
| border-color: @mauve !important; | ||
| outline: none !important; |
There was a problem hiding this comment.
outline-style: none would probably work? But we shouldn't get rid of native/default focus outlines really.
| .signin-button { | ||
| background-color: @mauve !important; | ||
| color: @base !important; | ||
| border: none !important; |
There was a problem hiding this comment.
If the original site has a border, so should we.
| background-color: @mauve !important; | ||
| color: @base !important; | ||
| border: none !important; | ||
| font-weight: bold !important; |
uncenter
removed
the
5.needs: staff-review
|
|
|
sorry guys my grandpa is in hospital since one week |
I'm so sorry to hear that. Please, don't feel any rush to complete or work on this. I hope your grandfather feels better soon. ❤️
For what it is worth, I don't think this is necessary. I'd rather you keep working on this branch rather than creating a new pull request. |
3 participants
Description
Adds a new userstyle for GeeksforGeeks.
Notes:
@versionto the required placeholder2000.01.01(automated versioning).