Fixed the PG->DuckDB translator to handle TPCH queries #3100
+261
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahan-activeloop
requested review from
ashotshakhkyan,
azat-manukyan,
Copilot,
davidbuniat and
khustup2
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the PostgreSQL to DuckDB SQL translator to properly handle TPCH (Transaction Processing Performance Council Benchmark) queries by addressing two critical translation issues: BETWEEN clause handling and column names containing SQL keywords.
- Enhanced WHERE clause predicate wrapping to use word boundaries when detecting AND/OR operators
- Added BETWEEN clause tracking to prevent incorrect splitting of
BETWEEN...ANDsyntax - Implemented comprehensive test coverage for both BETWEEN clauses and column names with keyword substrings
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| postgres/tests/py_tests/test_pg_duck_translation.py | Added two new test cases covering BETWEEN clause translation and column names containing SQL keywords, with multiple test scenarios for each |
| cpp/deeplake_pg/pg_to_duckdb_translator.cpp | Modified WHERE clause parser to track BETWEEN clauses and use word boundary checks when identifying AND/OR operators |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vahan-activeloop
force-pushed
the
vahan/translate-fix
branch
from
0626542 to
8440083
Compare
|
khustup2
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
Things to be aware of
Things to worry about
Additional Context