Skip to content

Conversation

@mattnite
Copy link
Contributor

@mattnite mattnite commented Jan 4, 2026

This patch adds two chips and boards, the MSP430F5529, MSP430G2553, and thier Launch Pad boards. My first microcontroller class was taught with an MSP430F5529, so this is very full circle for me. I have these boards on order and will test before merging.

There's also a couple more details I need finalized before the merge:

  • Generate register code from targetdb
  • Investigate correct compiler and ubsan rt configurations
  • write blinky example
  • Implement memset, memcpy, and abort in assembly
  • Set stack on startup
  • Create an interrupt vector (fine if it's hardcoded at first)
  • Map vector table to memory
  • Add PORT hal
  • Add watchdog hal
  • Add external crystals to board

Fixes #813

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 7 issues on changed lines in 6 files:

  • port/stmicro/stm32/src/hals/STM32F103/adc.zig: 1 issue
  • port/stmicro/stm32/src/hals/STM32F103/i2c.zig: 1 issue
  • port/stmicro/stm32/src/hals/common/i2c_v2.zig: 1 issue
  • port/stmicro/stm32/src/hals/common/util.zig: 1 issue
  • port/texasinstruments/msp430/src/boards/MSP-EXP430F5529LP.zig: 1 issue
  • port/texasinstruments/msp430/src/hal/gpio.zig: 2 issues
ℹ️ Additional issues on unchanged lines
The following 32 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:125: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:329: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/build.zig:25: TODO style comments need to have a linked microzig issue on the same line.
port/raspberrypi/rp2xxx/src/hal/dma.zig:120: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/adc.zig:374: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:309: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:30: Suggestion: Rename `RccPeriferals` to `RCC_Periferals`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/spi.zig:28: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/uart.zig:1: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/uart.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:25: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:69: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:80: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:113: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:13: Suggestion: Rename `I2CError` to `I2C_Error`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:21: Suggestion: Rename `TimingSpec_Standard` to `TimingSpecStandard`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/timer_v1.zig:169: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/timer_v1.zig:172: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/timer_v1.zig:24: Suggestion: Rename `ARRModes` to `ARR_Modes`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/timer_v1.zig:112: Suggestion: Rename `CCConfig` to `CC_Config`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/timer_v1.zig:173: Suggestion: Rename `GPTimer` to `GP_Timer`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/timer_v1.zig:542: Suggestion: Rename `PWMChConfig` to `PWM_ChConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:82: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:87: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:14: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:150: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:173: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.

⚠️ Could not attach inline comments due to an error.

@github-actions github-actions bot dismissed their stale review January 4, 2026 10:39

Updating with new lint results

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 3 issues on changed lines in 2 files:

  • port/texasinstruments/msp430/src/boards/MSP-EXP430F5529LP.zig: 1 issue
  • port/texasinstruments/msp430/src/hal/gpio.zig: 2 issues
ℹ️ Additional issues on unchanged lines
The following 4 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:125: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:329: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.

@github-actions github-actions bot dismissed their stale review January 4, 2026 10:42

Updating with new lint results

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

ℹ️ Additional issues on unchanged lines
The following 4 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:125: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:329: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

ℹ️ Additional issues on unchanged lines
The following 4 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:125: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:329: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.

Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped over the regz/sorcerer stuff. Just had a few ideas for debugging improvements, all optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MSP430 port

4 participants