Skip to content

Conversation

@rmnbrd
Copy link
Contributor

@rmnbrd rmnbrd commented Jan 5, 2026

Summary

Tiny PR moving the new announcement-banner to its own shared lib.

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

One day they will all understand

@rmnbrd
Copy link
Contributor Author

rmnbrd commented Jan 5, 2026

/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425

@RemiBonnet
Copy link
Member

Qovery Preview

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - impr(announcement-banner): move announcement banner to a shared lib - 2026-01-05T09:56:51Z

Another comment will be posted when deployments are finished

@rmnbrd rmnbrd force-pushed the impr/announcement-banner branch from 39cc680 to edc7544 Compare January 5, 2026 09:58
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.12%. Comparing base (c72c4a6) to head (60ee13e).
⚠️ Report is 2 commits behind head on staging.

Files with missing lines Patch % Lines
...ibs/shared/ui/src/lib/components/banner/banner.tsx 0.00% 0 Missing and 2 partials ⚠️
...rc/lib/announcement-banner/announcement-banner.tsx 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2275      +/-   ##
===========================================
- Coverage    50.06%   48.12%   -1.94%     
===========================================
  Files          407     1200     +793     
  Lines         9268    21273   +12005     
  Branches      2806     6258    +3452     
===========================================
+ Hits          4640    10238    +5598     
- Misses        3736     9114    +5378     
- Partials       892     1921    +1029     
Flag Coverage Δ
unittests 48.12% <85.00%> (-1.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet
Copy link
Member

Qovery Preview

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console

@rmnbrd rmnbrd marked this pull request as ready for review January 5, 2026 10:12
@rmnbrd rmnbrd merged commit b1d8855 into staging Jan 5, 2026
9 of 10 checks passed
@rmnbrd rmnbrd deleted the impr/announcement-banner branch January 5, 2026 14:07
@RemiBonnet
Copy link
Member

🎉 This PR is included in version 1.263.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants