TRT support for MAISI #8153
Merged
TRT support for MAISI #8153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
…ppers Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
KumoLiu
reviewed
Oct 31, 2024
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
KumoLiu
reviewed
Nov 8, 2024
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Contributor
|
/build |
Contributor
|
/build |
KumoLiu
approved these changes
Nov 14, 2024
yiheng-wang-nv
added a commit
to Project-MONAI/model-zoo
that referenced
this pull request
Dec 12, 2024
### Description TRT optimization support for MAISI. Depends on Project-MONAI/MONAI#8153 To successfully export MAISI, either 24.11 PyTorch container (or latest public Torch nightly) is needed, or this patch needs to be applied to 24.10-based container: ``` --- /usr/local/lib/python3.10/dist-packages/torch/onnx/symbolic_opset14.bak 2024-10-09 01:38:04.920316673 +0000 +++ /usr/local/lib/python3.10/dist-packages/torch/onnx/symbolic_opset14.py 2024-10-09 01:38:25.228053951 +0000 @@ -148,7 +148,6 @@ is_causal and symbolic_helper._is_none(attn_mask) ), "is_causal and attn_mask cannot be set at the same time" - scale = symbolic_helper._maybe_get_const(scale, "f") if symbolic_helper._is_none(scale): scale = _attention_scale(g, query) --------- Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Yiheng Wang <vennw@nvidia.com> Co-authored-by: Yiheng Wang <vennw@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added trt_compile() support for Lists and Tuples in arguments for forward() - needed for MAISI.
Did not add support for grouping return results yet - MAISI worked with explicit workaround unrolling the return results.
Notes
To successfully export MAISI, either latest Torch nightly is needed, or this patch needs to be applied to 24.09-based container:
Types of changes