Streamlined Rearrange in SpatialAttentionBlock #8130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
for more information, see https://pre-commit.ci
Nic-Ma
approved these changes
Oct 10, 2024
Contributor
|
PR looks good to me, please ensure the logic is covered by unit tests. Thanks. |
KumoLiu
approved these changes
Oct 10, 2024
Contributor
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
Hi @borisfom, thanks for the update. Overall looks good to me.
We've already code freeze for version 1.4, and QA is expected to complete their testing by the end of this week. As a result, this PR may not be included in the 1.4 release. Thank you for your understanding!
Contributor
Author
|
/build |
Contributor
Author
|
@KumoLiu : Sure, obviously it doesn't make it to 1.4, so the target is dev branch. Can we get it merged? |
Contributor
|
/build |
Contributor
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rearrange code failed dynamo export in 24.09 container:
pytorch/pytorch#137629
While we can't still use dynamo export with TRT in 23.09, I also noticed that my workaround improved runtime by about 1 second end-to-end for 100 seconds run.
Description
Replaced einops Rearrange with reshape/transpose
Types of changes