14.0 fix queue job cron jobrunner #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use FIFO, firt createad job will be treat first * if priority are different it take the precedent Yet we are not using channel priority into account
petrus-v
force-pushed
the
14.0-fix-queue_job_cron_jobrunner
branch
from
158ff89 to
148fb90
Compare
sbidoul
approved these changes
Apr 14, 2024
Member
sbidoul
left a comment
sbidoul
left a comment
There was a problem hiding this comment.
Given the documentation of the ChannelJob class, this fix looks correct
Channel jobs are comparable according to the following rules:
* jobs with an eta come before all other jobs
* then jobs with a smaller eta come first
* then jobs with a smaller priority come first
* then jobs with a smaller creation time come first
* then jobs with a smaller sequence come first
Member
|
cc/ @simahawk |
Contributor
|
This PR has the |
Member
|
@simahawk care to review? |
Contributor
Author
|
Hi @ivantodorovich ! I hope this finds you well :) As you are the maintainer of this module do you mind to review and merge it if you're fin with it ? |
Member
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 28460c6. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.