-
Notifications
You must be signed in to change notification settings - Fork 73
StreamTest no longer needs the HostIrLowering knob. #5748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
!test |
Description
|
| Relevant files | |||
|---|---|---|---|
| Enhancement |
|
PR Reviewer Guide
Here are some key observations to aid the review process:
| 🧪 PR contains tests |
| ⚡ Recommended focus areas for review |
Test Behavior Change
|
Test failures
-
(High, 44)
NCCL NVLS multicast bind failure in multidevice / nvfuser test suites (dlcluster_viking_ci)Test Name H100 (dist.) Source tests.python.multidevice.test_communication.test_allgather ❌ tests.python.multidevice.test_communication.test_allgather_expanded_broadcast ❌ tests.python.multidevice.test_communication.test_allreduce ❌ tests.python.multidevice.test_communication.test_reduce_scatter ❌ tests.python.multidevice.test_communication.test_reduce_scatter_noncontiguous ❌ tests.python.multidevice.test_dtensor.test_column_parallel_linear ❌ tests.python.multidevice.test_dtensor.test_plus_one ❌ tests.python.multidevice.test_dtensor.test_row_parallel_linear ❌ tests.python.multidevice.test_expert_parallel.test_dispatch_and_combine ❌ tests.python.multidevice.test_matmul.test_column_parallel_grouped_mm ❌ ... with 34 more test failures omitted. Check internal logs. -
(Medium, 1)
NCCL invalid usage errors in multidevice overlap tests (tests/python/multidevice)Test Name H100 (dist.) Source tests.python.multidevice.test_overlap.test_overlap_allgather_matmul_shard_outermost[backend_type=CommunicatorBackend.cuda] ❌
Greptile SummaryThis PR simplifies the
The change is consistent with recent work to decouple Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as StreamTest
participant Base as NVFuserTest
participant Options as EnableOptionsGuard
participant KE as KernelExecutor
Note over Test,KE: Before: StreamTest with HostIrLowering
Test->>Base: Construct (inherits from NVFuserTest)
Test->>Options: set(EnableOption::HostIrLowering)
Test->>KE: compile(&fusion, args)
Test->>KE: run(args, outputs)
Note over Test,KE: After: StreamTest as alias
Test->>Base: Use NVFuserTest directly (type alias)
Note over Options: No HostIrLowering option set
Test->>KE: compile(&fusion, args)
Test->>KE: run(args, outputs)
Note over KE: KernelExecutor works without HostIrLowering flag
|
No description provided.