fix: serialize Pydantic models in request body #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lapinek
requested review from
kenany
and removed request for
a team and
kenany
Issue: - ExtraInfo class instance submitted as the extra_info parameter is not serialized and results in: "TypeError: Object of type ExtraInfo is not JSON serializable" This fix will: - Serialize BaseModel instances. - Exclude None values (automatically populated for defined model properties and rejected by the API) This will allow users to pass as extra_info parameter: - ExtraInfo instance (as hinted) - Dictionary
lapinek
force-pushed
the
kl/fix-model-serialization
branch
from
196c2fd to
c614988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
This fix will:
This will allow users to pass as extra_info parameter: