Better delete task workflow for tasks with family (vibe-kanban) #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the changes: Successfully implemented a better delete task workflow that properly handles task family relationships: 1. **Database Migration** (`crates/db/migrations/20251007000000_set_null_parent_task_attempt_on_delete.sql`): - Updated the `parent_task_attempt` foreign key constraint from the default behavior to `ON DELETE SET NULL` - This ensures that when a task attempt is deleted, child tasks are decoupled rather than deleted 2. **Backend - Database Layer** (`crates/db/src/models/task.rs`): - Added `find_children_by_parent_task_id()` method to find all child tasks created by any attempts of a given parent task 3. **Backend - API Layer** (`crates/server/src/routes/tasks.rs`): - Updated `delete_task()` endpoint to check for child tasks before deletion and log them - Added `get_task_children()` endpoint to fetch child tasks for a given task - Updated analytics to track the number of child tasks affected 4. **Frontend - API Client** (`frontend/src/lib/api.ts`): - Added `getChildren()` method to fetch child tasks for a given task 5. **Frontend - UI** (`frontend/src/components/dialogs/tasks/DeleteTaskConfirmationDialog.tsx`): - Added loading and display of child tasks before deletion - Shows a warning with the list of child tasks that will be decoupled - Displays up to 3 child task names with a count of remaining ones 6. **MCP Server** (`crates/server/src/mcp/task_server.rs`): - Updated `delete_task` tool description to clarify that child tasks are decoupled, not deleted - Updated success message to inform about decoupled children - When a task is deleted, all its attempts are deleted (CASCADE) - Child tasks that were created by those attempts have their `parent_task_attempt` set to NULL (decoupled) - The UI warns users about child tasks that will be affected - Child tasks remain in the project and can continue to be worked on independently All code compiles successfully and sqlx queries have been prepared.
ggordonhall
approved these changes
Oct 14, 2025
mbernier
pushed a commit
to mbernier/vibe-kanban
that referenced
this pull request
Nov 2, 2025
… of the changes: (BloopAI#970) Successfully implemented a better delete task workflow that properly handles task family relationships: 1. **Database Migration** (`crates/db/migrations/20251007000000_set_null_parent_task_attempt_on_delete.sql`): - Updated the `parent_task_attempt` foreign key constraint from the default behavior to `ON DELETE SET NULL` - This ensures that when a task attempt is deleted, child tasks are decoupled rather than deleted 2. **Backend - Database Layer** (`crates/db/src/models/task.rs`): - Added `find_children_by_parent_task_id()` method to find all child tasks created by any attempts of a given parent task 3. **Backend - API Layer** (`crates/server/src/routes/tasks.rs`): - Updated `delete_task()` endpoint to check for child tasks before deletion and log them - Added `get_task_children()` endpoint to fetch child tasks for a given task - Updated analytics to track the number of child tasks affected 4. **Frontend - API Client** (`frontend/src/lib/api.ts`): - Added `getChildren()` method to fetch child tasks for a given task 5. **Frontend - UI** (`frontend/src/components/dialogs/tasks/DeleteTaskConfirmationDialog.tsx`): - Added loading and display of child tasks before deletion - Shows a warning with the list of child tasks that will be decoupled - Displays up to 3 child task names with a count of remaining ones 6. **MCP Server** (`crates/server/src/mcp/task_server.rs`): - Updated `delete_task` tool description to clarify that child tasks are decoupled, not deleted - Updated success message to inform about decoupled children - When a task is deleted, all its attempts are deleted (CASCADE) - Child tasks that were created by those attempts have their `parent_task_attempt` set to NULL (decoupled) - The UI warns users about child tasks that will be affected - Child tasks remain in the project and can continue to be worked on independently All code compiles successfully and sqlx queries have been prepared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task is deleted, we don't deal with child tasks/parent attempts correctly. We should decouple them, not delete everything.