Fix GitHub PR link opening incorrectly when URL lacks protocol prefix (Vibe Kanban) #1558
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary I added URL normalization to the backend in `vibe-kanban/crates/remote/src/routes/review.rs`: 1. **Added `normalize_github_url` helper function** (lines 129-137) - Checks if the URL already has `http://` or `https://` prefix, and if not, prepends `https://` 2. **Applied normalization in `init_review_upload`** (lines 217-218) - The URL is now normalized before being stored in the database This ensures that all GitHub PR URLs stored in the database will have the correct `https://` protocol prefix, preventing the browser from treating them as relative paths when used in `<a href>` attributes.
Vibe Kanban Review FailedUnfortunately, the code review could not be completed. Review ID: |
stunningpixels
changed the title
Vibe Kanban Review FailedUnfortunately, the code review could not be completed. Review ID: |
2 similar comments
Vibe Kanban Review FailedUnfortunately, the code review could not be completed. Review ID: |
Vibe Kanban Review FailedUnfortunately, the code review could not be completed. Review ID: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the GitHub PR link at the top of the review page would open incorrectly when the stored URL lacked the
https://protocol prefix.Problem
When a GitHub PR URL was submitted without the protocol prefix (e.g.,
github.com/owner/repo/pull/123instead ofhttps://github.com/owner/repo/pull/123), the link would open as a relative path, resulting in broken URLs likehttps://api.vibekanban.com/review/github.com/...instead of navigating to GitHub.Solution
Added URL normalization in the backend's
init_review_uploadhandler to ensure all GitHub PR URLs are stored with thehttps://prefix:normalize_github_url()helper function that:http://orhttps://prefixhttps://if no protocol is presentWhy Backend?
This PR was written using Vibe Kanban